Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RegExp Intents and retrieving parameters from them. #794

Merged
merged 4 commits into from
Dec 26, 2019

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Dec 23, 2019

Closes #793

This PR adds:

  • Support to use RegExp as intents
  • Attaches a new matches property to the CommandListenerInvocation that is a RegExpExecArray that contains the raw intent that was typed along with the matches to the intent regex (if it was supplied)
  • Depends on Enable RegExp for intents automation-client#637
  • Will update package.json once 637 is merged

@ipcrm ipcrm requested a review from cdupuis December 23, 2019 23:15
@ipcrm ipcrm added auto-merge-method:squash Auto-merge with squash and merge auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section labels Dec 26, 2019
@ipcrm ipcrm changed the title [DO NOT MERGE] Support RegExp Intents and retrieving parameters from them. Support RegExp Intents and retrieving parameters from them. Dec 26, 2019
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atomist atomist bot merged commit 417c4f5 into master Dec 26, 2019
@atomist
Copy link
Contributor

atomist bot commented Dec 26, 2019

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist atomist bot deleted the ipcrm_793 branch December 26, 2019 14:05
atomist bot pushed a commit that referenced this pull request Dec 26, 2019
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter Support for Regex Intents
2 participants