diff --git a/lib/workflow/questionnaire.js b/lib/workflow/questionnaire.js index d113180e0..793505949 100644 --- a/lib/workflow/questionnaire.js +++ b/lib/workflow/questionnaire.js @@ -217,7 +217,7 @@ exports.askScaffold = { }, { value: 'scaffold-navigation', message: 'Navigation App', - hint: 'Add a router and some sample routes, Bootstrap v3 and Font Awesome v4.' + hint: 'Add a router and some sample routes, Bootstrap v4 and Font Awesome v5.' }] }; diff --git a/package-lock.json b/package-lock.json index ea3b14d7a..e091c1613 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "aurelia-cli", - "version": "1.2.3", + "version": "1.3.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/skeleton/docker/Dockerfile b/skeleton/docker/Dockerfile index 955134d0b..a7c46f19c 100644 --- a/skeleton/docker/Dockerfile +++ b/skeleton/docker/Dockerfile @@ -107,9 +107,6 @@ COPY --from=publish-stage /app/wwwroot/ . // @endif // @if feat["cli-bundler"] && !feat["dotnet-core"] - // @if feat["scaffold-navigation"] -COPY --from=publish-stage /app/bootstrap/dist/ ./bootstrap/dist/ - // @endif COPY --from=publish-stage /app/scripts/ ./scripts/ COPY --from=publish-stage /app/index.html/ . // @endif diff --git a/skeleton/protractor/protractor.conf.js b/skeleton/protractor/protractor.conf.js index 3bcbdbedb..69d73b34a 100644 --- a/skeleton/protractor/protractor.conf.js +++ b/skeleton/protractor/protractor.conf.js @@ -56,7 +56,8 @@ const config = { '--disable-renderer-backgrounding', '--disable-device-discovery-notifications', '--no-sandbox', - '--disable-dev-shm-usage' + '--disable-dev-shm-usage', + '--window-size=1024,768' ] } }, diff --git a/skeleton/scaffold-navigation/aurelia_project__if_cli-bundler/aurelia.json b/skeleton/scaffold-navigation/aurelia_project__if_cli-bundler/aurelia.json index db0b977d3..980c36d90 100644 --- a/skeleton/scaffold-navigation/aurelia_project__if_cli-bundler/aurelia.json +++ b/skeleton/scaffold-navigation/aurelia_project__if_cli-bundler/aurelia.json @@ -5,25 +5,15 @@ "name": "vendor-bundle.js", "prepend": [ "node_modules/whatwg-fetch/dist/fetch.umd.js" - ], - "dependencies": [ - { - "name": "bootstrap", - "deps": ["jquery"], - "path": "../node_modules/bootstrap", - "main": "dist/js/bootstrap.min" - } ] } ], "copyFiles": { // @if feat.web - "node_modules/bootstrap/dist/fonts/*": "bootstrap/dist/fonts", - "node_modules/font-awesome/fonts/*": "font-awesome/fonts", + "node_modules/@fortawesome/fontawesome-free/webfonts/*": "@fortawesome/fontawesome-free/webfonts", // @endif // @if feat['dotnet-core'] - "node_modules/bootstrap/dist/fonts/*": "wwwroot/bootstrap/dist/fonts", - "node_modules/font-awesome/fonts/*": "wwwroot/font-awesome/fonts", + "node_modules/@fortawesome/fontawesome-free/webfonts/*": "wwwroot/@fortawesome/fontawesome-free/webfonts", // @endif } } diff --git a/skeleton/scaffold-navigation/package.json b/skeleton/scaffold-navigation/package.json index b8ed99b08..4f853a23d 100644 --- a/skeleton/scaffold-navigation/package.json +++ b/skeleton/scaffold-navigation/package.json @@ -2,8 +2,9 @@ "dependencies": { "whatwg-fetch": "^3.0.0", "aurelia-fetch-client": "^1.0.0", - "bootstrap": "^3.3.6", - "font-awesome": "^4.6.3", + "bootstrap": "^4.4.1", + "popper.js": "^1.16.1", + "@fortawesome/fontawesome-free": "^5.12.1", "jquery": "^3.3.1" } } \ No newline at end of file diff --git a/skeleton/scaffold-navigation/src/app.html b/skeleton/scaffold-navigation/src/app.html index 668be6212..20aae306f 100644 --- a/skeleton/scaffold-navigation/src/app.html +++ b/skeleton/scaffold-navigation/src/app.html @@ -1,6 +1,6 @@ diff --git a/skeleton/scaffold-navigation/test__if_protractor/e2e/demo.e2e.ext b/skeleton/scaffold-navigation/test__if_protractor/e2e/demo.e2e.ext index 7317edf93..f57795043 100644 --- a/skeleton/scaffold-navigation/test__if_protractor/e2e/demo.e2e.ext +++ b/skeleton/scaffold-navigation/test__if_protractor/e2e/demo.e2e.ext @@ -43,7 +43,6 @@ describe('aurelia skeleton app', function() { it('should navigate to users page', async () => { await poSkeleton.navigateTo('#/users'); - browser.sleep(200); await expect(await poSkeleton.getCurrentPageTitle()).toBe('Github Users | Aurelia'); }); }); diff --git a/skeleton/scaffold-navigation/test__if_protractor/e2e/skeleton.po.ext b/skeleton/scaffold-navigation/test__if_protractor/e2e/skeleton.po.ext index 43e3dfb09..805def298 100644 --- a/skeleton/scaffold-navigation/test__if_protractor/e2e/skeleton.po.ext +++ b/skeleton/scaffold-navigation/test__if_protractor/e2e/skeleton.po.ext @@ -11,5 +11,6 @@ export class PageObjectSkeleton { const navigatingReady = browser.waitForRouterComplete(); await element(by.css('a[href="' + href + '"]')).click(); await navigatingReady; + await browser.sleep(200); } }