Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update benchmark gas values based on new NEAR wasm cost #310

Closed
3 tasks done
birchmd opened this issue Oct 18, 2021 · 0 comments · Fixed by #315
Closed
3 tasks done

Update benchmark gas values based on new NEAR wasm cost #310

birchmd opened this issue Oct 18, 2021 · 0 comments · Fixed by #315
Assignees
@birchmd
Labels
A-benchmark Area: performance benchmarks

Comments

@birchmd
Copy link
Member

birchmd commented Oct 18, 2021 •
edited
Loading

NEAR recently lowered the gas cost of wasm op codes. This means our contract should cost much less gas now. The purpose of this issue is to confirm that is the case and update the regression tests we have accordingly.

  • Update NEAR dependencies to latest
    • Note: you may also need to update the NEAR SDK dependencies (which is on our fork of the SDK) since they also depend on nearcore libraries
  • Run tests and check new gas values (will need to add some temporary printlns for this)'
  • Update tests to reflect new gas upper bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@birchmd birchmd

Labels
A-benchmark Area: performance benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat(benchmarks): update gas bounds after wasm cost reduction aurora-is-near/aurora-engine
1 participant
@birchmd