Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace logging #372

Open
joshuajbouw opened this issue Nov 22, 2021 · 1 comment
Open

Trace logging #372

joshuajbouw opened this issue Nov 22, 2021 · 1 comment
Assignees
Labels
A-engine Area: purely engine EVM related C-enhancement Category: New feature or request P-high Pririoty: high

Comments

@joshuajbouw
Copy link
Contributor

joshuajbouw commented Nov 22, 2021

As per previous discussions in #356 (comment), we require logging in the Engine which we will be able to utilise to print out logs not just through NEAR logging, but also straight to console or a file for the standalone.

Per discussion with @andrcmdr, he had mentioned that this tracing crate is superior to the log crate mentioned in the discussions. I do agree, it will give us more details than the log crate.

Right now, we only support logging to NEAR. We need to also log through other methods which is useful for the standalone.

Logs should be done anytime an event has taken place. For example, if someone calls a function, we should return a log who had called that function.

Additionally, it would be worth it to see if logs that are emitted could possibly be captured and turned into NEAR logs. That would be a better instead of the current framework we have now which checks for which feature is enabled, and uses that logging method.

@joshuajbouw joshuajbouw added C-enhancement Category: New feature or request P-high Pririoty: high A-engine Area: purely engine EVM related labels Nov 22, 2021
@birchmd
Copy link
Member

birchmd commented Dec 6, 2021

Note the additional place to use logging: #379 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-engine Area: purely engine EVM related C-enhancement Category: New feature or request P-high Pririoty: high
Projects
None yet
Development

No branches or pull requests

3 participants