Update ft metadata #53
Conversation
style: update documentation style: follow commitlint convension fix: releasing process error
There was a problem hiding this comment.
@0x3bfc I'm really sorry about the delay. The main branch refactor for v2 is now merged, so you can rebase your changes.
I think we should try to keep @near-eth/utils functional so that it doesn't depend on the state of other packages like @near/client
| @@ -0,0 +1,32 @@ | |||
| import { ethers } from 'ethers' | |||
| import { getMetadata } from '@near-eth/nep141-erc20/dist/natural-erc20' | |||
There was a problem hiding this comment.
I think we should try to avoid making connector packages a dependency of @near-eth/utils to avoid the circular import.
For flexibility, the api of updateFungibleTokenMetadata can take a provider, nearAccount and metadata values as argument so that it can be used independently of @near-eth/client.
| @@ -29,10 +30,17 @@ export function setEthProvider (provider: any): any { | |||
| return ethProvider | |||
| } | |||
|
|
|||
| export function getAuroraProvider (): any { | |||
| auroraJsonRpcProvider = () => new ethers.providers.JsonRpcProvider({ | |||
There was a problem hiding this comment.
We are removing process.env from the library. getAuroraProvider should return the provider which was set by setAuroraProvider.
Thanks for the review ... I've rebased the PR and will fix the conflicts and your comments. |
|
@0x3bfc can you address conflicts and Pierre comments to merge this PR. I plan to use it for |
closes #48