Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting SegDataGenerator to Keras? #8

Open
ahundt opened this issue Mar 28, 2017 · 6 comments
Open

Submitting SegDataGenerator to Keras? #8

ahundt opened this issue Mar 28, 2017 · 6 comments

Comments

@ahundt
Copy link
Collaborator

ahundt commented Mar 28, 2017

Would you be interested in submitting or giving permission to submit SegDataGenerator to keras?

It would first go through keras-contrib as per the Keras instructions for pull requests.

I wouldn't mind doing the integration, I can make sure credit is properly given as well.

@aurora95
Copy link
Owner

Of course it'll be great if you can help submitting it. But you need to make sure it can support 'th' dim_ordering correctly, which I've never checked. And I guess it's also needed to fix lots of my dirty codes...... Anyway it will be really appreciated if you can help, at least this can give an example for those who wanna use keras to do image segmentation.

@ahundt
Copy link
Collaborator Author

ahundt commented May 4, 2017

Just to update, I've been doing some code cleanup and working to get all the pieces in so an example can also be included in keras-contrib. I've submitted pull requests for:

Eventually, the code, particularly SegDataGenerator, will likely need to be moved to most likely an image.py in keras_contrib/preprocessing equivalent to the location of ImageDataGenerator in keras.

The model creation code might then go into applications, and train.py would go into a single file with multiple command line options in https://github.com/farizrahman4u/keras-contrib/tree/master/examples.

It may be possible to handle the tensorflow vs theano part later on, as long as tf isn't called directly in anything under keras_contrib that is not in the tensorflow backend.

@ahundt
Copy link
Collaborator Author

ahundt commented May 8, 2017

Update: François Chollet, Keras' author, said he is interested in directly incorporating dense prediction/FCN into the Keras API, so I'm seeking suggestions/feedback at keras-team/keras#6538

@Irtza
Copy link

Irtza commented May 12, 2017

@ahundt @aurora95 I tried to add SegDataGenerator to my utils in my source. I cannot import it from there after rebuilding keras python setup.py install.
I'm not sure if its a general question or particular to this code.

@ahundt
Copy link
Collaborator Author

ahundt commented May 12, 2017

@Irtza I'd appreciate if your question could be in a separate github issue. A setup.py pull request would be welcome, or just add it to your PYTHONPATH.

@Irtza
Copy link

Irtza commented May 12, 2017

Okay I will add more details on the roadblocks while using the segDataGenerator in another issue on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants