-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookies com.auth0.auth.* have no secure flag #1050
Comments
@garyfreeman - The cookie that it's setting with that name is just a nonce/state value, something that's not important to protect and only used be Auth0.js. We set the cookie, attach the value to the authorize URL, redirect, then check the value when it comes back. There's nothing in that value that's sensitive and it's not meant to be sent anywhere. I'll close this for now but let me know if you have any other questions here. |
@joshcanhelp - Even though no critical data is stored, for some security audits, any cookie that is not secured will be a blocking issue. Any chance we could add the option to add the |
This is a blocking issue for us after having penetration test done as @jgautheron stated it could be. It seems like a simple fix, would it be possible to address this? The |
@joshcanhelp, this has been a blocking issue for us with pen test. Same as @andrewphahn and @jgautheron mentioned above. |
We can probably do something like what we do here in Auth0 SPA SDK, we we set the |
@stevehobbsdev, this looks like a great solution. |
I've raised #1158 that should fix this, will be included in the next release 👍 |
@stevehobbsdev great job! When is next release is scheduled for? |
@NikitaKoren We don't have a schedule as such, but there is a piece of work in flight that we want to put into the release as well. I anticipate being able to do a release early next week. |
Description
Cookies created after calling to WebAuth.authorize method have no secure flag when using https protocol.
Reproduction
Environment
The text was updated successfully, but these errors were encountered: