Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we process transactions #740

Closed
luisrudge opened this issue Apr 13, 2018 · 3 comments
Closed

Refactor how we process transactions #740

luisrudge opened this issue Apr 13, 2018 · 3 comments

Comments

@luisrudge
Copy link
Contributor

var params = objectHelper
    .merge(this.baseOptions, [
      'clientID',
      'responseType',
      'redirectUri',
      'scope',
      'audience',
      '_csrf',
      'state',
      '_intstate',
      'nonce'
    ])
    .with(options);
  params = this.transactionManager.process(params);

snippets like this are all over the place. Ideally, we should abstract this so we don't have to copy/paste everywhere

@luisrudge
Copy link
Contributor Author

test

@luisrudge luisrudge reopened this Apr 13, 2018
@lbalmaceda
Copy link
Contributor

Worth noting that as of today, if you need to add or remove a value from that array you'll need to change it everywhere.

@luisrudge
Copy link
Contributor Author

With #787, it was pretty clear this is a deeper issue with how we pick and choose which param goes in and out. Needs more thought and it will probably break users, so we'll leave this to the next major as a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants