Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack overflow exception with Autofac 5.1.1 and circular dependencies #1085

Closed
atuzovic opened this issue Feb 16, 2020 · 3 comments
Closed
Labels
Milestone

Comments

@atuzovic
Copy link

After the upgrade to 5.1.1 version, all our solutions have started to crash due to the stack overflow, leaving us with no possibility to capture exception or the cause of it.

We have managed to isolate the behavior in the following repository:
https://github.com/App-Impact-Labs/ISSUE-AutofacStackoverflowException

The code sample above has coupling between 3 classes/interfaces, with circular dependencies.

The solution will crash instantly with Autofac 5.1.0. / 5.1.1.

If you downgrade Autofac to 5.0.0. the solution will start and return response.

Have there been any breaking changes regarding the registration of circular dependencies?

@alexmg alexmg closed this as completed in 7bc8648 Feb 16, 2020
@alexmg
Copy link
Member

alexmg commented Feb 16, 2020

The issue is caused by d485f39 which was fixing a decorator related issue. I am going to send a fix through CI now.

@alexmg alexmg added the bug label Feb 16, 2020
@alexmg alexmg added this to the v5.1.2 milestone Feb 16, 2020
@alexmg
Copy link
Member

alexmg commented Feb 16, 2020

@atuzovic I have pushed a 5.1.2 package with the fix to NuGet.

@atuzovic
Copy link
Author

Thanks @alexmg for quick intervention, we can confirm that everything is working properly now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants