Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set function counters to zero at startup #59

Open
5 of 7 tasks
emschwartz opened this issue Jun 20, 2023 · 3 comments
Open
5 of 7 tasks

Set function counters to zero at startup #59

emschwartz opened this issue Jun 20, 2023 · 3 comments

Comments

@emschwartz
Copy link
Contributor

emschwartz commented Jun 20, 2023

As discussed in https://github.com/orgs/autometrics-dev/discussions/31, we would like for the function call counter to be initialized to zero, at least in development mode. This is to enable UIs built on top of Autometrics + Prometheus to discover the names of the instrumented functions before the service has received any traffic.

@brettimus
Copy link
Contributor

Do we need to update the queries in the grafana dashboard to make sure the error ratio does not divide by zero? (I know we just removed > 0 from a lot of queries to fix the dashboards, but i think this would only apply to the denominator for the error ratio query)

This caused an issue in the explorer, but grafana might be smarter about handling NaNs

@emschwartz
Copy link
Contributor Author

@brettimus probably

@P2P-Nathan
Copy link

I've taken a look through the C# implementation and this doesn't look feasible with the design, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants