Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to turn the autometrics feature on/off #79

Open
pradeepcdlm opened this issue Jul 26, 2023 · 3 comments
Open

Configuration to turn the autometrics feature on/off #79

pradeepcdlm opened this issue Jul 26, 2023 · 3 comments

Comments

@pradeepcdlm
Copy link

Is there is any single point of configuration to turn the autometrics feature in a code base. What would be the model or pattern we have to use. Why I'm asking this question because in case of a performance bottleneck, and we need to turn this feature off, then what is the best approach we can do.

@IvanMerrill
Copy link

Hi Pradeep. Good question! There is no single point of configuration, or a feature flag or similar that could be used to turn autometrics off currently. You would have to do a code deploy after removing the decorators in order to remove the monitoring as it stands.

In terms of performance bottlenecks there have been some performance tests for some of the libraries that I'll try and dig out for you that might alleviate some of your fears. Don't forget that autometrics is built on top of prometheus and OTeL libraries which are already widely used and tested in production!

@pradeepcdlm
Copy link
Author

Thanks @IvanMerrill for your quick response. Since the code spread over the entire code base and if we want to disable this due to some reason for example a performance bottleneck , for example. If we have a model like there is a pointcut expression that allows us to define a condition to be checked before execute the autometrics code, just like aspect oriented programming do.

@IvanMerrill
Copy link

I completely understand your point! I have added this as an idea on the discussions page. Feel free to add more information to this page if there's anything you would like to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants