Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Class decorators break in the browser when using the init function #113

Closed
stephlow opened this issue Aug 25, 2023 · 1 comment · Fixed by #115
Closed

🐛 Class decorators break in the browser when using the init function #113

stephlow opened this issue Aug 25, 2023 · 1 comment · Fixed by #115
Assignees
Labels
bug Something isn't working

Comments

@stephlow
Copy link
Member

Environment information

What happened?

In the current implementation, when you use a class decorator and a custom init configuration, the decorator will run before the init function.

Because of this, it will try to spin up a PrometheusExporter, even though we configure a push gateway in the init function.

Expected result

The class decorator should use the configuration provided in the init call

@keturiosakys
Copy link
Member

Good catch thank you! Notably this won't just break in the browser: because the decorator resolves before any other code is run (even the first init function) - any custom exporter configuration will be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants