Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An error found in influence-models #83

Open
WenqianZhao opened this issue Oct 16, 2018 · 3 comments
Open

An error found in influence-models #83

WenqianZhao opened this issue Oct 16, 2018 · 3 comments

Comments

@WenqianZhao
Copy link

In influence_models.py line 115, the code is:
tmp_used = used[:i] + used[i:]
This line doesn't remove the ith element in used, maybe what you really want is sth like:
tmp_used = used[:i] + used[i+1:]
and also need to check whether i+1 is out of range.
For now, because 'tmp_used' is the same as 'used', backward pass actually did nothing.

@WenqianZhao
Copy link
Author

Also in line 119 and 120, maybe we should use 'tmp_used' instead of 'used'?

@AndreBiedenkapp
Copy link
Collaborator

Thank you for reporting this issue.
The influence-models are currently not supported and not tested so there might be more issues with the influence-models.

@WenqianZhao
Copy link
Author

Thank you for reporting this issue.
The influence-models are currently not supported and not tested so there might be more issues with the influence-models.

OK, thanks for your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants