Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obstacle_stop_planner does not work for backward driving #1697

Open
3 tasks done
kosuke55 opened this issue Aug 25, 2022 · 4 comments
Open
3 tasks done

obstacle_stop_planner does not work for backward driving #1697

kosuke55 opened this issue Aug 25, 2022 · 4 comments
Assignees
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned)

Comments

@kosuke55
Copy link
Contributor

kosuke55 commented Aug 25, 2022

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

obstacle_stop_planner does not work for backward driving but publishes the path of the input as it is.

// TODO(someone): support backward path
const auto is_driving_forward = motion_utils::isDrivingForwardWithTwist(input_msg->points);
is_driving_forward_ = is_driving_forward ? is_driving_forward.get() : is_driving_forward_;
if (!is_driving_forward_) {
RCLCPP_WARN_THROTTLE(
get_logger(), *get_clock(), 3000, "Backward path is NOT supported. publish input as it is.");
path_pub_->publish(*input_msg);
return;
}

  • Only obstacle_cruise_planner works for backward driving.
  • Some modules(pull_over, pull_out) generate backward path.

Purpose

To enable stopping at obstacles when backward driving.

Possible approaches

Implement an algorithm to stop for obstacles on the backward path.

Definition of done

Ensure that it is possible to stop at obstacles when backward driving.

@kosuke55 kosuke55 added component:planning Route planning, decision-making, and navigation. (auto-assigned) status:help-wanted Assistance or contributors needed. labels Aug 25, 2022
@kosuke55
Copy link
Contributor Author

@mitsudome-r @TakaHoribe
Please allow me to share this as pull_over and pull_out will enable backward driving by default.

@kosuke55
Copy link
Contributor Author

add the limitation for backward driving to docs of obstacle_stop_planner
#1696

@stale
Copy link

stale bot commented Oct 24, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Oct 24, 2022
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Nov 2, 2022
@stale
Copy link

stale bot commented Jan 1, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) status:help-wanted Assistance or contributors needed. status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

1 participant