Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raw vehicle cmd converter might skip computation during run time #2151

Closed
3 tasks done
taikitanaka3 opened this issue Oct 25, 2022 · 1 comment · Fixed by #2152
Closed
3 tasks done

raw vehicle cmd converter might skip computation during run time #2151

taikitanaka3 opened this issue Oct 25, 2022 · 1 comment · Fixed by #2152
Assignees
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)

Comments

@taikitanaka3
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

if raw vehicle cmd converter interpolate this accel map(just an example) which is not decent order for a part (1.0, 0.9, 3.0)

default,0.0,  10.0,  20.0
0,      1.0,  11.0,  21.0
0.5,    0.9,  22.0,  42.0
1.0,    3.0,  46.0,   42.0

Purpose

to remove sudden accident during run time, validation for map is necessary

Possible approaches

to validate if it's correct order before the run time

Definition of done

feature above is merged

@taikitanaka3 taikitanaka3 self-assigned this Oct 25, 2022
@taikitanaka3 taikitanaka3 added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Oct 25, 2022
@taikitanaka3
Copy link
Contributor Author

TODO
make unit test for this case and see if this is validated

default,0.0,  10.0,  20.0
0,      1.0,  11.0,  21.0
0.5,    0.9,  22.0,  42.0
1.0,    3.0,  46.0,   42.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant