Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traffic_light_roi_visualizer does not handle signal with arrow indicator (in Japan) #8389

Closed
3 tasks done
YoshiRi opened this issue Aug 7, 2024 · 6 comments
Closed
3 tasks done
Assignees
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)

Comments

@YoshiRi
Copy link
Contributor

YoshiRi commented Aug 7, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

traffic_light_roi_visualizer does not show entire detection results when following traffic lights.

image
image

We want visualizer to show every traffic light detection results.
That would be something like:

●: 100%
← : 100%
↑: 100%

Purpose

We want to distinguish detection error and visualization error.

Possible approaches

First of all, all of the detection results should be visualized.
The easiest solution is to concatenate visualization text with vertically or horizontally.

●: 100%
← : 100%
↑: 100%
●, ←, ↑
100, 100, 100

Definition of done

When we confirmed all of the detection results should be visualized.

Currently TIER IV has the sample data. TIER IV INTERNAL DATA LINK, if there are someone interested in this issue, we will annonimise and share this rosbag.

@YoshiRi YoshiRi added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 7, 2024
@kminoda
Copy link
Contributor

kminoda commented Aug 8, 2024

@KhalilSelyan
Hi, would you address this issue? I think this is due to your PR: #6985. Since this may cause misunderstanding of the Autoware's performance, we would like to fix it as soon as possible. What we would like to see is that all the possible patterns as a traffic light classification output is properly checked.
(One of our members within TIER IV approved your PR, but should've checked from our end, sorry for that)

Thank you for your contribution as always 🙏

@kaancolak
Copy link
Contributor

Hi @kminoda -san, this doesn't seem to be related to me. Maybe @KhalilSelyan might be able to help

@kminoda
Copy link
Contributor

kminoda commented Aug 8, 2024

Sorry for that 🙏 Fixed

@ktro2828
Copy link
Contributor

ktro2828 commented Aug 9, 2024

@KhalilSelyan Hi I've created a PR to fix this problem. Could you review that? #8428

@ktro2828
Copy link
Contributor

#8428 has been merged

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Aug 27, 2024

I will close this issue with #8428 has been merged

@YoshiRi YoshiRi closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

4 participants