Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test script to compile test files with elm-make before and after formatting #36

Open
avh4 opened this issue Oct 22, 2015 · 3 comments

Comments

@avh4
Copy link
Owner

avh4 commented Oct 22, 2015

This only needs to be done for the test files that are compatible with the latest version of Elm.

@avh4 avh4 added this to the 1.0.0 MVP milestone Oct 22, 2015
@Janiczek
Copy link
Contributor

I just want to be sure I understand correctly before trying anything:

Do we compare the two generated .js files and want them to be the same?

Do we FAIL the tests if

  • the file is not valid before formatting (elm-make throws error)
  • the file is valid before but not valid after formatting (elm-make throws error)
  • the afterFormatting.js file is not the same as original.js (diff shows something)

and SUCCESS otherwise?

@Janiczek
Copy link
Contributor

Janiczek commented Dec 9, 2015

@avh4 bump... :) could you please just clarify? I can then try to do this.

@avh4
Copy link
Owner Author

avh4 commented Dec 9, 2015

Failing if elm-make fails before or after is the most important.

I hadn't thought of comparing the js. That sounds like it could be useful, though I'm not 100% certain that the js will never change because of formatting. I think the comparison would be good to have, but it's less important than just making sure elm-make can still parse the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants