Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Multi-language video filename support #7

Open
Jonathan-Asher opened this issue Jun 21, 2023 · 2 comments
Open

[Bug] Multi-language video filename support #7

Jonathan-Asher opened this issue Jun 21, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Jonathan-Asher
Copy link

Describe the bug

When downloading a video with a non-english name, the extension can not save the downloaded file.

How to reproduce

Download a video with a non-english name, for example: https://youtu.be/EG4CnWBXXSs

Expected behavior

Uncaught (in promise) Error: ffmpeg.FS('readFile', 'EG4CnWBXXSs-ד"ר מיכאל בזיוריאנו - למה לא לנסות?.mp4') error. Check if the path exists
at Object.R [as FS] (background.js:1:9049)
at Et (background.js:1:34230)
at async Ft (background.js:1:37280)

What browser(s) can you reproduce the issue on?

Brave

What OS does it occur on?

macOS

What's the version you're running?

latest

Additional context

No response

@Jonathan-Asher Jonathan-Asher added the bug Something isn't working label Jun 21, 2023
@avi12
Copy link
Owner

avi12 commented Jun 21, 2023

Sounds like an issue with https://npm.im/@ffmpeg/ffmpeg, but maybe it got fixed since, who knows
Unfortunately, as you can probably tell from the commit history, I don't maintain this project as I have more important projects in mind that I wish to execute
Though if you can create a PR that fixes the issue, I can certainly review it and merge it

@avi12
Copy link
Owner

avi12 commented Jun 21, 2023

Keep in mind that this extension relies on the old Manifest V2 specification, so while it might be possible to fix the non-English filename support, a long-term solution must be done, which is migration to Manifest V3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants