Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issue with card grid view only on tabs #3214

Open
2 of 5 tasks
m7madmagdy opened this issue Sep 3, 2024 · 4 comments · May be fixed by #3255
Open
2 of 5 tasks

UI issue with card grid view only on tabs #3214

m7madmagdy opened this issue Sep 3, 2024 · 4 comments · May be fixed by #3255
Assignees
Labels
Bug Something isn't working Style UI This issue is related to the UI

Comments

@m7madmagdy
Copy link

Context

If you have a gride view with full controls plus reorder controls the delete button will be outside the card view
this issue happens only on tabs not in the main resource index view

System configuration

Avo version: 3.12.0

Rails version: 7.2

Ruby version: 3.3.4

License type

  • Community
  • Pro
  • Advanced

Are you using Avo monkey patches, overriding views or view components?

  • Yes. If so, please post code samples.
  • No

Screenshots or screen recordings

IMG-20240903-WA0002

@Paul-Bob Paul-Bob added UI This issue is related to the UI Bug Something isn't working Style labels Sep 3, 2024
@Aaryanpal
Copy link
Contributor

Aaryanpal commented Sep 10, 2024

@Paul-Bob can i work on this?

@Paul-Bob
Copy link
Contributor

Sure @Aaryanpal thanks for the initiative!

For the approach I guess wrapping the controls on a flex box and making them to verticaly expand should do the trick

@Aaryanpal
Copy link
Contributor

Aaryanpal commented Sep 14, 2024

@Paul-Bob Could you please guide me on how to navigate to this specific screen? I’ve completed the setup but am unable to locate the screen.

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Sep 16, 2024

The screenshot was taken from @m7madmagdy's project.

To reproduce a similar behavior go to http://localhost:3030/admin/resources/posts

To simulate more controls on the card go to app/components/avo/index/resource_controls_component.html.erb and triplicate the <%= render_control control %> line.

Don't forget to remove the triplicated controls after fixing the styling.

@Aaryanpal Aaryanpal linked a pull request Sep 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Style UI This issue is related to the UI
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants