New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sizeForHumans returning incorrect unit value #3

Closed

jeffgreco13 opened this issue Jun 22, 2022 · 1 comment

jeffgreco13 commented Jun 22, 2022

The current method attempts to divide the model's size attribute directly. This small adjustment returns the correct unit:

        public function sizeForHumans(int $precision = 1): string
	{
		$units = ["B", "KiB", "MiB", "GiB", "TiB", "PiB"];
		$size = $this->size;
		for ($i = 0; $size > 1024; $i++) {
			$size /= 1024;
		}

		return round($size, $precision) . " " . $units[$i];
	}

awcodes mentioned this issue

Jgreco updates #8

Merged

Owner

awcodes commented Jun 22, 2022

This has been released in https://github.com/awcodes/filament-curator/releases/tag/v0.2.5

awcodes closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment