-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MyIP #630
Comments
Unfortunately, it seems there are no tagged releases. Rather then pull from main/latest all the time, users should be able to verify that its stable and have changelogs, etc. We can check back in around 4 months from the first stable tagged release. If i'm wrong, feel free to remove the needs to mature tag others, thanks! |
Thank you for your reply and for understanding my concerns. My program runs directly using the JS source code and does not require complex binary compilation, so there's no need to specifically output a distribution version. In fact, if a distribution is forced, the code in the main branch remains the same. Additionally, the changelog for each version is clearly stated within the program, specifically in /src/locales/en.json, and it is also listed in the About section on the official website. My code has been released for 5 months now, and if possible, I hope you will consider including it again. Thank you. |
Thanks for weighing in, as there is a changelog i'm sure that's sufficient enough and its visible for users to consider updating their code to the latest version. I shall remove the label and just double confirm |
@jason5ng32 what about starting using This would make it easy for users to deploy a particular version, and upgrade when they feel like it/after reviewing changes, instead of always running the latest |
Hi @nodiscc Thank you for your suggestion. I find it very valuable. While downloading code directly from the main branch is indeed convenient, creating different versions does help users distinguish between features and choose their preferred version to use. Following your advice, I have created the release for version 3.6: https://github.com/jason5ng32/MyIP/releases/tag/v3.6 . I hope you will consider my project again. Over the past few months, my program has gained many stars and forks, and many people have created their own hosted versions using my code. Thank you. |
Can you reconsider my project? @nodiscc @kokomo123 |
We will include your project after it's been around 4 months since you've now started creating git tags, so feel free to check in/around |
Hi, it's been 4 months, and I have already created git tags and released several versions. |
Apologies for the delay, we will review the PR that just got made recently. 👍🏻 ref. #820 |
Solved with commit 34c4e78 |
Thanks for taking the time to suggest an addition to awesome-selfhosted!
Please fill out information below (all fields are mandatory unless noted otherwise):
To ensure your issue is dealt with swiftly, please check the following (check the boxes
[x]
):The text was updated successfully, but these errors were encountered: