Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib.awful.taglist): multiple tag selection #39

Closed
wants to merge 2 commits into from

Conversation

actionless
Copy link
Member

multiple tag selection wasn't highlighting properly when *_occupied is set in theme table

multiple tag selection wasn't highlighting properly when *_occupied is set in theme table
@psychon
Copy link
Member

psychon commented Aug 24, 2014

That merge commit seems useless and I don't see why I should pull that.

For the actual issue: I don't understand what you are trying to fix. The commit message says that this is due to *_occupied, but uhm.... dunno.

What does this have to do with selecting multiple tags? Any ideas how the code can be simplified? Moving the check for t.selected around would also likely leave behind some dead code... at least there are other places checking for t.selected as well. I'm confused.

Also, sorry for my slow reaction to this.

@actionless
Copy link
Member Author

For the actual issue: I don't understand what you are trying to fix. The commit message says that this is due to *_occupied, but uhm.... dunno.

to reproduce that:

  1. set in theme.lua (which will be loaded by beautiful module) theme.taglist_font, theme.taglist_fg_occupied, theme.taglist_bg_occupied, theme.taglist_fg_empty, theme.taglist_bg_empty, theme.taglist_fg_focus, theme.taglist_bg_focus to different colors
  2. select multiple tags (AFAIR, by default it's binded to modkey+ Control + {1,2,3...})

in that situation multiple selected tags are colored using theme.taglist_fg_occupied, theme.taglist_bg_occupied colors instead of theme.taglist_fg_focus, theme.taglist_bg_focus

@psychon
Copy link
Member

psychon commented Aug 24, 2014

Ok. I have to agree that the behavior is way better with your change.

Could you get rid of that additional merge commit? Or is it ok if I just cherry pick your commit?

@actionless
Copy link
Member Author

i think cherry-picking should be ok

@psychon
Copy link
Member

psychon commented Aug 24, 2014

Cherry picked as commit 9390534

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants