feat: output registry URI if single registry ID is provided as input #50
Conversation
| @@ -85,6 +85,37 @@ describe('Login to ECR', () => { | |||
| expect.anything()); | |||
| }); | |||
|
|
|||
| test('outputs the registry ID if a single registry is provided in the input', async () => { | |||
| core.getInput = jest.fn().mockReturnValueOnce('111111111111'); | |||
There was a problem hiding this comment.
should the mocked return value be registries: { with: [1111111111] } ?
EDIT: ugh I realize this was backwards; but the below comment saw what I was getting at :P
There was a problem hiding this comment.
Do you mean to mock the configuration:
- name: Login to Amazon ECR
id: login-ecr
uses: aws-actions/amazon-ecr-login@v1
with:
registries: 1111111111
The GH actions toolkit takes care of parsing the config, and then the action just does core.getInput('registries')
|
I used this update with the Is it possible that setting |
|
@allisaurus ah, looks like my branch's changes aren't packaged into dist folder, so your action isn't running the change. |
|
Ah ha! That did it, it's working no problem now. |
Related to #48,
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.