feat: logout docker registries in post step #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareliguori
requested review from
a team,
piradeepk and
allisaurus
and removed request for
a team,
piradeepk and
allisaurus
piradeepk
reviewed
Aug 5, 2020
cleanup.js
Outdated
Comment on lines
34
to
37
| if (exitCode != 0) { | ||
| core.debug(doLogoutStdout); | ||
| throw new Error('Could not logout: ' + doLogoutStderr); | ||
| } |
There was a problem hiding this comment.
Would it make more sense to try to log out of all of the registries and then throw an error with which ones failed instead of failing after the first?
There was a problem hiding this comment.
Yup that makes sense, fixed in latest commit
piradeepk
approved these changes
Aug 9, 2020
|
Due to this change, our CI pipeline broke. We have multiple workers on the same machine (same docker daemon) and now while they are pushing things to docker, as soon as one job finishes, it will wipe the credentials for the other jobs. Is there a way to make this behaviour optional? |
|
@rubenfonseca Thanks for reporting this, I'll cut and issue and we'll work on a fix. |
|
@rubenfonseca in the meantime you can pin to a previous version of the action to get unblocked. See #77 |
|
That’s what we did and it worked. Thank you very much!
… On 13 Aug 2020, at 20.52, allisaurus ***@***.***> wrote:
@rubenfonseca in the meantime you can pin to a previous version of the action to get unblocked. See #77
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the post-job cleanup, do a
docker logoutfor all registries that had a successfuldocker loginvia this action.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.