fix(@aws-amplify/auth): correctly throw the error when the refresh token is expired #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuth
reviewed
Aug 24, 2018
| @@ -864,37 +864,37 @@ export default class AuthClass { | |||
| rej(err); | |||
| return; | |||
| } | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
Can we add a unit test that ensures the these functions are not called concurrently
yuth
reviewed
Aug 27, 2018
| expect.assertions(1); | ||
| const spyon3 = jest.spyOn(CognitoUser.prototype, 'getUserData'); | ||
|
|
||
| expect.assertions(2); | ||
| try { | ||
| await auth.currentUserPoolUser(); | ||
| } catch (e) { |
There was a problem hiding this comment.
This test should be re-written to use expect().toThrow. The tests are more readable with this change
There was a problem hiding this comment.
The test will fail when using toThrow to catch a rejection. I followed the suggestion in this thread: jestjs/jest#1377 (comment)
yuth
approved these changes
Aug 28, 2018
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes #1468
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.