Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add Signer classes to consumer proguard rules #3310

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

mattcreaser
Copy link
Member

@mattcreaser mattcreaser commented Jun 2, 2023

Issue #, if available: #3302

Description of changes: Add rules to the consumer proguard file to keep the various Signer classes instantiated reflectively by SignerFactory. AGP 8 enables R8 full-mode optimization, which normally removes unreferenced constructors.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This prevents the R8 full-mode optimizer from removing the constructors for these classes since they are instantiated via reflection.
@mattcreaser mattcreaser requested a review from a team as a code owner June 2, 2023 13:49
@mattcreaser mattcreaser merged commit 79e42d1 into main Jun 5, 2023
@mattcreaser mattcreaser deleted the mattcreaser/gradle-8-proguard branch June 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants