Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Customizations Codebuild Jobs Access to Customer Defined ASM Secrets #455

Open
addefisher opened this issue May 1, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@addefisher
Copy link

Describe the outcome you'd like

I would like the terraform-aws-control_tower_account_factory module to expose a variable called var.customization_codebuild_secrets`

  • The value of this variable would be a map of environment variable names -> SecretsManager secret names
  • Each key in this map would be added to the aft-global-customizations-terraform and aft-account-customizations-terraform Codebuild projects as a SecretsManager driven environment variable (whose value is the corresponding key)
  • The identity policy on the role used by these CodeBuild projects would also need to be updated accordingly.

This would allow AFT customers to leverage AFT to deploy non-AWS resources as customizations (for example, an Okta group per AFT managed account).

Is your feature request related to a problem you are currently experiencing? If so, please describe.

Yes, we would like to use AFT to deploy non-AWS resources as customizations, but we do not have a clean way to provide credentials for non-AWS Terraform providers to the customization CodeBuild projects.

Additional context

@addefisher addefisher added the enhancement New feature or request label May 1, 2024
@snebhu3
Copy link
Collaborator

snebhu3 commented Jun 21, 2024

@addefisher thank you for reaching out.
Please may you elaborate on the ask with examples and snippets to ensure we understand the requirement better.
Please may you also expand on if you have already explored achieving the goal with existing capabilities (pre-/post api helpers etc. ) and what were the challenges there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants