-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: refactor Logger
types and interfaces to improve consistency and clarity
#1729
Comments
Another task, though simple, is to relocate type HandlerMethodDecorator to commonso/utils/lambda. It appears to be duplicated in the core modules This has the added benefit that we can add commons as a dev dependency for modules that will implement handler decorators but don't need anything from logger (though obviously as dev dependency and declaring the import as a type it doesn't matter a whole lot). Just seems cleaner to me. |
Hi @codyfrisch, you're right and making this change makes sense. We have already moved that type in the v2 branch and switched to using it in some of the utilities. I haven't switched Logger to use it yet because I wanted to see if #1744 would be merged first, but I'm planning to. |
|
This is available in preview starting from the |
Summary
Review all type and interface definitions and usage throughout the codebase to identify opportunities for refactoring and clean up. This will help improve consistency in naming, structure, and usage of types across the project.
Specific areas to investigate:
any
where more specific types could be definedas const
typesWhy is this needed?
As the project has grown organically, inconsistencies in how types are defined and used have emerged. By refactoring and cleaning these up, we can improve maintainability, clarity, and reliability of the codebase.
More consistent and intention-revealing names will also improve onboarding and comprehension as well as DX.
Converting usage to proper types where applicable will enable stronger compiler checking and editor tooling support. Overall, this refactoring will leave the code in better shape for continued development and maintenance.
Which area does this relate to?
No response
Solution
Examples of types/interfaces/objects that could be improved:
ClassThatLogs
(here) might be converted to an interface, renamed, and made to include all methodsConstructorOptions
(here) could be renamed to something more explanatory likeLoggerOptions
or similar (check other utilities)LogJsonIndent
(here) should be moved out of this file and into aconstants.ts
file similar to what done in other utilities, also it should be converted to an object as we are moving away from enums.Important
Before starting to work on a PR for this issue, the assignee should do an investigation of the code and propose an action plan under this issue.
Once the plan has been discussed and agreed upon with at least one maintainer work on the PR can start.
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: