Maintenance: refactor Metrics
types and interfaces to improve consistency and clarity
#1731
Closed
1 of 2 tasks
Labels
completed
This item is complete and has been merged/shipped
good-first-issue
Something that is suitable for those who want to start contributing
metrics
This item relates to the Metrics Utility
Milestone
Summary
Review all type and interface definitions and usage throughout the codebase to identify opportunities for refactoring and clean up. This will help improve consistency in naming, structure, and usage of types across the project.
Specific areas to investigate:
any
where more specific types could be definedas const
typesWhy is this needed?
As the project has grown organically, inconsistencies in how types are defined and used have emerged. By refactoring and cleaning these up, we can improve maintainability, clarity, and reliability of the codebase.
More consistent and intention-revealing names will also improve onboarding and comprehension as well as DX.
Converting usage to proper types where applicable will enable stronger compiler checking and editor tooling support. Overall, this refactoring will leave the code in better shape for continued development and maintenance.
Which area does this relate to?
No response
Solution
Examples of types/interfaces/objects that could be improved:
MetricsInterface
(here) should be moved to thetypes
folder as well as documented via commentsMetricResolution
(here) should be moved out of the types and into theconstants.ts
file since it's not a typeMetricUnits
(here) should be moved out of the types and into theconstants.ts
file since it's not a type, also the name should be made singular i.e.MetricUnit
HandlerDecorator
(here) could probably be moved into thecommons
package and reused elsewhere, since we have a copy at least in another package (Tracer)Important
Before starting to work on a PR for this issue, the assignee should do an investigation of the code and propose an action plan under this issue.
Once the plan has been discussed and agreed upon with at least one maintainer work on the PR can start.
Acknowledgment
Future readers
Please react with 👍 and your use case to help us understand customer demand.
The text was updated successfully, but these errors were encountered: