Adding section 9.1: Gated Recurrent Units (GRU) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
approved these changes
Mar 29, 2021
| " Y = H.dot(W_hq).add(b_q);\n", | ||
| " outputs.add(Y);\n", | ||
| " }\n", | ||
| " return new Pair(outputs.size() > 1 ? NDArrays.concat(outputs) : outputs.get(0), new NDList(H));\n", |
There was a problem hiding this comment.
Doesn't it work on outputs.size() == 1?
There was a problem hiding this comment.
Nope, if I am not mistaken that's the reason I had done that. It threw an error otherwise.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "public static NDArray normal(Shape shape, Device device) {\n", |
There was a problem hiding this comment.
actually DJL will detect system GPU and use it if applicable. So I think you can remove the device parameter here. If you check TensorFlow implementation, they don't have this param as it do it in DJL way as well.
There was a problem hiding this comment.
Ohh I just saw randomNormal uses the NDArray device by default if you don't specify. Cool, I'll remove it.
There was a problem hiding this comment.
I'll be doing this in another PR as it covers multiple sections
markbookk
added a commit
to markbookk/d2l-java
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding section 9.1: Gated Recurrent Units (GRU), based on original http://d2l.ai/chapter_recurrent-modern/gru.html