Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbor filters( format, watermark) are not working. #109

Closed
grendach opened this issue Jun 20, 2019 · 4 comments
Closed

thumbor filters( format, watermark) are not working. #109

grendach opened this issue Jun 20, 2019 · 4 comments

Comments

@grendach
Copy link

grendach commented Jun 20, 2019

I've tried to run and play with serverless-image-handler.
What I've found is that some thumbor filters are not working as expected.
For example:

  • filter filters:format(webp) doesn't want to format image into webp. When you will try to save formatted picture it will be still in origin format (*.jpg in my case)
  • filter filters:watermark(imageUrl, x, y, alpha [, w_ratio [, h_ratio]]) doesn't show watermark on my picture at all.
    I've compared serverless-image-handler setup with original thumbor installation( thumbor as docker image on my laptop) and above filters are working as expected.
    Would you be so kind to check if these filters working for you?
@hayesry
Copy link
Member

hayesry commented Jun 20, 2019

Hey @grendach: thanks for the heads up on the mappings not working as expected for you. We'll look into this and make the necessary adjustments in an upcoming release!

@abalsekar
Copy link

Hey @hayesry

Could you post an example of a native Sharp JSON object for watermarking an image as the Thumbor filter mapping doesn't seem to be working. How do you add the path to watermark image, x position, y position and transparency to the object?

@TuNi54
Copy link

TuNi54 commented Jul 29, 2019

Hey @grendach: thanks for the heads up on the mappings not working as expected for you. We'll look into this and make the necessary adjustments in an upcoming release!

Hi, do you have any status please? The watermark filter doesn't work for me too.
Thanks

@beomseoklee
Copy link
Member

We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue.

For the way how you can create a watermark, you can refer to the implementation guide Appendix D: List of Supported Thumbor Filters.

You can also refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants