Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOURCE_BUCKETS has a limit and can't support a long list of buckets #141

Closed
harriswong opened this issue Aug 1, 2019 · 2 comments
Closed

Comments

@harriswong
Copy link

harriswong commented Aug 1, 2019

We would like to be able to set SOURCE_BUCKETS=developer-bucket-* so that each developer's bucket is in the whitelist.

This was okay in 3.0.0 but it stopped allowing * in 4.0.0. We tried adding all our dev buckets as a comma separated value string but we went out of string limit.

It would be good to support regex again. Here is a PR for the proof of concept:
#138

We tested this with a custom built the image and it works with SOURCE_BUCKETS=developer\-bucket\-.*.

@beomseoklee
Copy link
Member

We have updated our solution, and I believe your issue has been fixed. If you still see the issue with the latest version (v4.2), please feel free to reopen the issue.

However, as your pull request says, it only accepts the regular expression after launching the solution.

You can refer to the recent changes here

@harriswong
Copy link
Author

cc @crpahl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants