Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400x0 is resulting in a empty response #183

Closed
OBrown92 opened this issue Feb 7, 2020 · 4 comments
Closed

400x0 is resulting in a empty response #183

OBrown92 opened this issue Feb 7, 2020 · 4 comments

Comments

@OBrown92
Copy link

OBrown92 commented Feb 7, 2020

First of all, thanks for all the effort in this project and especially in the new update 4.2.
Unfortunately one thing from the Pull Request #130 of rpong is still not working. If I only set one size and leave the other '0', then the response is empty.

@beomseoklee
Copy link
Member

Thanks for your input, @OBrown92
I've seen the Thumbor manual regarding image resize, and resize needs to be improved definitely.

We would improve this one at the next release.

@sniprmonk4
Copy link

Thanks for your input, @OBrown92
I've seen the Thumbor manual regarding image resize, and resize needs to be improved definitely.

We would improve this one at the next release.

@beomseoklee any idea when the next release will be? We are also seeing this issue and working on a temporary fix.

@beomseoklee
Copy link
Member

@OBrown92 and @sniprmonk4

This is the beta version AWS CloudFormation template of the next release.
https://solutions-features-reference.s3.amazonaws.com/serverless-image-handler/v4.2.1-beta.1/serverless-image-handler.template

This beta release fixes 2 issues:

  1. The solution can support 0 resize value (e.g. 0x300, 300x0, 0x0).
  2. As Thumbor's default resizing algorithm is crop, I've changed the default resizing algorithm to crop, which is cover by default in Sharp, for the Thumbor style URL.

Once again that is beta version to fix only this issue, I would recommend testing the feature first prior to adapting this one to your environment.

I hope this would help you.

@beomseoklee
Copy link
Member

@OBrown92
Thanks for waiting. This one is fixed in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants