New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant Use of Promise #189

Closed

avin-kavish opened this issue Feb 20, 2020 · 2 comments

avin-kavish commented Feb 20, 2020

Not that it's a problem but I don't think you need to return a promise out of an async function explicitly. Async functions always return promises.

https://github.com/awslabs/serverless-image-handler/blob/19cbc3ce759d7c8d8ddc35081972d7ac1daf0c71/source/image-handler/image-handler.js#L176

Member

beomseoklee commented Feb 20, 2020

@avin-kavish , you are right, and thanks for your opinion. We would consider this one in the next release.

Member

beomseoklee commented Nov 19, 2020

This one is updated in the latest version.

tomnight closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment