Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Issues on V 4.2 #205

Closed
mberneis opened this issue Apr 11, 2020 · 3 comments
Closed

Performance Issues on V 4.2 #205

mberneis opened this issue Apr 11, 2020 · 3 comments

Comments

@mberneis
Copy link

I noticed a degrade in performance going from Version 4.1 to Version 4.2

(No WebP enabled - Querystring Cache breaking enabled in cloudfront)

V 4.1:
https://d147ewtskziry6.cloudfront.net/eyJidWNrZXQiOiJuYW5vY2hpcC1wZXQtcGljdHVyZXMtZGV2Iiwia2V5IjoiUGV0UGljXzEyMzMyMTEyMzMucG5nIiwiY2FjaGUiOiIxNTg2NjE5MjM1IiwiZWRpdHMiOnsicm90YXRlIjpudWxsfX0=?some_random_number

V 4.2:
https://d1bpkp55zv2eya.cloudfront.net/eyJidWNrZXQiOiJuYW5vY2hpcC1wZXQtcGljdHVyZXMtZGV2Iiwia2V5IjoiUGV0UGljXzEyMzMyMTEyMzMucG5nIiwiY2FjaGUiOiIxNTg2NjE5MjM1IiwiZWRpdHMiOnsicm90YXRlIjpudWxsfX0=?some_random_number

(For verification replace some_random_number with a timestamp or something random

For V 4.1 I am getting around 2.0 - 2.5 seconds
For V 4.2 I am getting around 3.5 - 4.0 seconds

Both go against the same bucket - all in region us-east-1

@beomseoklee
Copy link
Member

@mberneis Thanks for your observation. I'll take a look at what would cause more latency on v4.2.

@beomseoklee
Copy link
Member

Thanks for waiting, @mberneis

I figured out that the performance is because of changing output format to webp. Currently, v4.2 has a broken source code to enable automatic webp, so every file is converted to webp no matter what parameter you provided.

I found that converting the output format to webp takes a long time: around 2s. As a result, overall performance has been degraded. We will fix this one in the next release.

Once again, thanks for your investigation.

@beomseoklee
Copy link
Member

@mberneis
Thanks for waiting. This one is fixed in v5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants