Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inferImageType doesn't support binary/octet-stream but not application/octet-stream #306

Closed
eortiz-tracktik opened this issue Oct 8, 2021 · 2 comments

Comments

@eortiz-tracktik
Copy link

Is your feature request related to a problem? Please describe.
There is support to infer image type for binary/octet-stream and not application/octet-stream that is the recognized media type by IANA https://www.iana.org/assignments/media-types/media-types.xhtml

Describe the feature you'd like
I would like the support for infer the image type for application/octet-streamon ImageRequest.getOriginalImage()

if(originalImage.ContentType === 'binary/octet-stream' || originalImage.ContentType === 'application/octet-stream') {
                    const imageBuffer = Buffer.from(originalImage.Body);
                    this.ContentType = this.inferImageType(imageBuffer);
                    ...
@gattasrikanth
Copy link

Thanks for reporting the issue. I have added this to our backlog items list.

@fisenkodv
Copy link
Contributor

@eortiz-tracktik we have updated our solution, the issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.

You can refer to the recent changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants