Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] More flexible video quality selection #685

Open
kaizau opened this issue Nov 29, 2021 · 0 comments
Open

[FEATURE REQUEST] More flexible video quality selection #685

kaizau opened this issue Nov 29, 2021 · 0 comments
Labels
feature-request New feature or request

Comments

@kaizau
Copy link

kaizau commented Nov 29, 2021

Community Note

  • Please do not add additional comments such as "+1" or "me too" to existing issues - instead please vote on the issue by adding a 👍 to the issue. The Amazon Chime SDK team will prioritize the request based on the number of 👍 the issue has received.
  • Please go through the existing issues to see if your request has already been recommended.
  • Please do not use this template to report bugs. This repository has an issue template for issues and documentation to help with your development.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Tell us about your request

What do you want us to build?

For amazon-chime-sdk-component-library-react

Tell us about the problem you are trying to solve and why is it hard?

useSelectVideoQuality

  • This hook only offers 3 hardcoded video qualities. To add a custom video quality, we need to implement our own hook and components from scratch.
  • Unlike other Chime hooks, this doesn't provide access to the currently selected state. A useVideoQuality hook that returns the current quality and a setter would be more flexible.

<QualitySelection>

  • This dropdown component is curiously detached from the state it represents. It doesn't allow setting a default video quality, nor does it pick up on changes set by useSelectVideoQuality.

How are you currently solving a problem?

By rolling our own quality selector on top of audioVideo.chooseVideoInputQuality(). Yet this seems like a common use case that should be handled by the UI library.

Additional context

n/a

@kaizau kaizau added the feature-request New feature or request label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant