Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggleContentShare should await or return the calls to audioVideo.startContentShare in ContentShareProvider #852

Open
6 tasks done
CodySchaaf opened this issue Nov 14, 2022 · 1 comment
Labels
feature-request New feature or request

Comments

@CodySchaaf
Copy link

What happened and what did you expect to happen?

When you call toggleContentShare if the user hasn't given permission you can't catch the error and display a helpful message to assist them in fixing their permissions.

https://github.com/aws/amazon-chime-sdk-component-library-react/blob/main/src/providers/ContentShareProvider/index.tsx#L131

The above code should either await or return the promises so that the caller can catch any error.

Have you reviewed our existing documentation?

Reproduction steps

  • Remove screen capture permissions for chosen browser
  • Call toggleContentShare
  • Either add a .catch or wrap in a try/catch
  • the provided exception handling will not be called

Amazon Chime SDK React Components Library version

3.4.0

What browsers are you seeing the problem on?

all

Browser version

all

Device Information

all

Meeting and Attendee ID Information.

No response

Browser console logs

Uncaught (in promise) DOMException: Permission denied by system

Add any other context about the problem here.

No response

@devalevenkatesh devalevenkatesh added the feature-request New feature or request label Feb 11, 2023
@Kick933
Copy link

Kick933 commented Mar 29, 2024

This would be a really helpful for us also. Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants