Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnecting from a meeting fails and leaves the meeting audio session active. #193

Closed
jpmunoz9 opened this issue Dec 21, 2020 · 16 comments

Comments

@jpmunoz9
Copy link

Disconnecting from a meeting fails and leaves the meeting audio session active.

We started noticing it in:
Chime SDK: 0.12.1
Media SDK: 0.8.1

We also tried to reproduce this with following Android SDK but we never saw it happen:
Chime SDK: 0.8.1
Media SDK: 0.8.1

We reverted to the following builds as a workaround:
Chime SDK: 0.11.0
Media SDK: 0.7.0

Test Conditions:

  • Chime SDK: 0.13.0
  • Media SDK: 0.9.0
  • Network Connection: Wifi - Excellent
  • iOS: 14.3
  • Device: iPhone X

Reproduction Rate: Roughly 1 in 20 attempts.

Steps to reproduce:

  1. Join a meeting with audio and video that has at least 1 other participant.
  2. Stay in the meeting for 3 seconds.
  3. Leave the meeting.

Problem:
The audio session is still active and other participants can see you in the meeting.

Logs Captured:

When leaving the meeting succeeds:
2020-12-18 18:03:00.603478-0600 Meetings[4765:998236] [INFO] ViewController - API/DefaultAudioVideoFacade/stop
2020-12-18 18:03:00.603833-0600 Meetings[4765:998232] [INFO] ViewController - Stopping VideoClient
2020-12-18 18:03:00.734307-0600 Meetings[4765:997786] [INFO] ViewController - AudioClient State: finishDisconnecting Status: ok
2020-12-18 18:03:00.745344-0600 Meetings[4765:997786] [INFO] ViewController - videoClientDidStop
2020-12-18 18:03:00.745625-0600 Meetings[4765:998232] [INFO] ViewController - VideoClient is being destroyed

When leaving the meeting fails:
2020-12-18 18:37:44.437909-0600 Meetings[4825:1016844] [INFO] ViewController - API/DefaultAudioVideoFacade/stop
2020-12-18 18:37:44.438579-0600 Meetings[4825:1016844] [INFO] ViewController - Stopping VideoClient
2020-12-18 18:37:44.589417-0600 Meetings[4825:1015249] [INFO] ViewController - videoClientDidStop
2020-12-18 18:37:44.589730-0600 Meetings[4825:1016844] [INFO] ViewController - VideoClient is being destroyed

@hokyungh
Copy link
Contributor

Thank you for reporting. Do you know if you can reproduce on iPhone X only or do you know if this is reproducible on any other phone?

Could you also give us little more details on repro steps?

  1. Can I test with web vs mobile? or does it usually happen with mobile vs mobile meeting?
  2. Do you need to share your video or do we just wait for other displays to be shown?

@jpmunoz9
Copy link
Author

jpmunoz9 commented Dec 22, 2020

Hi @hokyungh, we've also seen it happen on an iPhone 12. I don't think this is device specific.

  1. Yes, you can test on web vs mobile. That's how I tested it.
  2. Yes, both clients were sharing video and audio. I would just wait for all video tiles to be loaded and then leave the meeting.

@tianyux-amz
Copy link
Contributor

Hi @jpmunoz9,

I tried to reproduce the issue in our demo app but failed. I did 50 attempts (since you mentioned the repro-rate is about 1/20) but I can always leave meeting properly and get audioSessionDidStopWithStatus callback as expected.

This is how I tried to reproduce the issue:

Environment

  • Attendee1: Joined through web serverless demo ([email protected]) on laptop.
  • Attendee2: Joined through iOS demo app (with Chime SDK v0.12.1 and Media SDK v0.8.1) on iPhone 6s with iOS 12.2.

Test Steps

  • Attendee1 joined meeting and enabled video.
  • Attendee2 joined the same meeting and enabled video as well. Both attendees were able to see two videos and hear each other.
  • Attendee2 left the meeting. Attendee1's roster was updated, and Attendee1 was not able to hear Attendee2 anymore.
  • Repeat the above test 50 times with different variants, e.g. Attendee2 joined with CallKit, Attendee2 joined before Attendee1, Attendee2 left meeting muted, Attendee2 did not enable video, etc.

Two questions for you:

  1. Were you testing your own application or the iOS demo app? If you were testing your own app, could you try to reproduce the issue with the iOS demo?
  2. Were you able to reproduce the issue on other iOS versions? Based on your comment, the issue should be iOS version irrelevant (since you cannot reproduce the issue with SDK v0.11.0 on iOS 14.3), but just want to double check.

Best,
Tianyu

@NehaSalve1393
Copy link

NehaSalve1393 commented Jan 6, 2021

I am also facing the same issue in my own React native app and I have also tested with demo app it is also having the same issue please replay ASAP
Test condition

  • chime sdk -0.13.0
  • media sdk - 0.9.0
  • ios - 14.0.1
  • Device -iPhone7

@tianyux-amz
Copy link
Contributor

I tried to reproduce the issue with using iPhone 12 Pro with iOS 14.3 and iPhone 6s with iOS 14.3, but I still couldn't reproduce the issue.

@NehaSalve1393 did you reproduced the issue using the ReactNative demo app, or the iOS demo app?

@NehaSalve1393
Copy link

@tianyux-amz I tried with React native demo app

@tianyux-amz
Copy link
Contributor

Got it, let me try to repro with that.

@tianyux-amz
Copy link
Contributor

I was able to reproduce the issue in the latest ReactNative demo. This seems related to #200.

Env: iPhone 6s with iOS 14.3, running SDK v0.12.2 and Media v0.8.2.

Steps:

  1. UserA joined meeting via web serverless demo.
  2. UserB joined meeting via RN demo and enabled video. Noticed the gree light in the status bar.
  3. UserB left meeting. Noticed the green light is still on. In the log I saw video client was stopped though:
RNDemo[4032:183886] [INFO] NativeMobileSDKBridge - API/DefaultAudioVideoFacade/stop
RNDemo[4032:183803] [INFO] NativeMobileSDKBridge - Stopping VideoClient
RNDemo[4032:183339] [INFO] NativeMobileSDKBridge - videoClientDidStop
  1. AudioClient was not disconnected successfully. UserA can still hear voice from UserB.

@NehaSalve1393
Copy link

@tianyux-amz is there any solution for this?

@tianyux-amz
Copy link
Contributor

We are root-causing the issue and will let you know once we have more findings.

@tianyux-amz
Copy link
Contributor

The issue was introduced in #151. Will talk to the PR author and come up with a proper fix.

@tianyux-amz
Copy link
Contributor

PR for the fix is being reviewed.

@jpmunoz9
Copy link
Author

jpmunoz9 commented Jan 8, 2021

Hi @tianyux-amz, for us it was also seen in our own React Native app. I'm glad you could reproduce this. Thank you.

@jpmunoz9 jpmunoz9 closed this as completed Jan 8, 2021
@tianyux-amz
Copy link
Contributor

We are preparing a hotfix release tonight. Will resolve the issue once the hotfix is out.

@tianyux-amz tianyux-amz reopened this Jan 8, 2021
@tianyux-amz
Copy link
Contributor

The fix was released. Please try out the latest SDK v0.13.1 and let us know if you run into any other issues. Thanks!

@NehaSalve1393
Copy link

@tianyux-amz now it's working fine.. Thank you so much for your quick help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants