Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI should respect eniConfig label if it already exists. #1593

Closed
backjo opened this issue Aug 26, 2021 · 0 comments · Fixed by #1596
Closed

CNI should respect eniConfig label if it already exists. #1593

backjo opened this issue Aug 26, 2021 · 0 comments · Fixed by #1596
Labels

Comments

@backjo
Copy link
Contributor

backjo commented Aug 26, 2021

What happened:

We currently have a set of nodes that use custom networking. As part of a new application being deployed, we want to give the pods on these nodes an ENIConfig that is different from the ENIConfig for other nodes in the cluster (which is set based on AZ). To try and achieve this, we provided userdata to this set of nodes to have the kubelet set an initial eniConfig label.

When the nodes start up, they are re-labeled by the CNI with the value of the label specified in ENI_CONFIG_LABEL_DEF (which ends up mapping to an AZ)

Attach logs

What you expected to happen:
I'd expect the CNI to respect the eniConfig label if it already set on the node.
How to reproduce it (as minimally and precisely as possible):
Set the eniConfig label in the kubelet configuration. Start and join the node to a K8S cluster with the CNI installed. Notice that the label is modified.
Anything else we need to know?:

I noticed that a workaround for this is possible by specifying the annotation, but from a user perspective, that's much harder to control/set compared to labels - labels can be set via kubelet options, whereas the annotation would need to be set by some controller or other component.

Environment:

  • Kubernetes version (use kubectl version): 1.21
  • CNI Version: 1.9.0
  • OS (e.g: cat /etc/os-release): BottleRocket 1.2.0
  • Kernel (e.g. uname -a):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant