From 58383a007977af8644267108c01df3dcf74865eb Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Fri, 19 Apr 2024 19:52:17 +0000 Subject: [PATCH] Added information on the build troubleshooting. --- README.md | 2 +- docs/troubleshooting.md | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index dccc7cf0fe..ecee7a37ef 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,7 @@ See [here](./docs/iam-policy.md) for required IAM policies. * `unit-test`, `format`,`lint` and `vet` provide ways to run the respective tests/tools and should be run before submitting a PR. * `make docker` will create a docker container using `docker buildx` that contains the finished binaries, with a tag of `amazon/amazon-k8s-cni:latest` * `make docker-unit-tests` uses a docker container to run all unit tests. -* builds for all build and test actions run in docker containers based on `golang:1.21.5-6-gcc-al2` unless a different `GOLANG_IMAGE` tag is passed in. +* Builds for all build and test actions run in docker containers based on `.go-version` unless a different `GOLANG_IMAGE` tag is passed in. ## Components diff --git a/docs/troubleshooting.md b/docs/troubleshooting.md index b631b8608f..559dbb325f 100644 --- a/docs/troubleshooting.md +++ b/docs/troubleshooting.md @@ -253,3 +253,11 @@ The [CNI image](../scripts/dockerfiles/Dockerfile.release) built for the `aws-no See the [cni-metrics-helper README](../cmd/cni-metrics-helper/README.md). + +## Build Troubleshooting + +If you encouter build issues while building vpc cni, ensure you are logged into a docker registry. +For e.g. + +aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws +~