fix(amplify): custom headers break with tokens #20395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`YAML.stringify` generates YAML with a fixed line length, splitting
long strings. This can split the token string value on multiple lines
making them unresolvable:
`${Token[AWS.URLSuf\\\n fix.2]}`
This can be the case with `Content-Security-Policy` headers with lots of
directives and referencing API endpoints in the `connect-src` for
example.
Get rid of `YAML.stringify` and generate this "simple" YAML string
"manually".
|
|
jogold
changed the title
rix0rrr
approved these changes
May 18, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
wphilipw
pushed a commit
to wphilipw/aws-cdk
that referenced
this pull request
May 23, 2022
`YAML.stringify` generates YAML with a fixed line length, splitting
long strings. This can split the token string value on multiple lines
making it unresolvable:
`${Token[AWS.URLSuf\\\n fix.2]}`
This can be the case with `Content-Security-Policy` headers with lots of
directives and referencing API endpoints in the `connect-src` for
example.
Get rid of `YAML.stringify` and generate this "simple" YAML string
"manually".
----
### All Submissions:
* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)
### Adding new Unconventional Dependencies:
* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)
### New Features
* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML.stringifygenerates YAML with a fixed line length, splittinglong strings. This can split the token string value on multiple lines
making it unresolvable:
${Token[AWS.URLSuf\\\n fix.2]}This can be the case with
Content-Security-Policyheaders with lots ofdirectives and referencing API endpoints in the
connect-srcforexample.
Get rid of
YAML.stringifyand generate this "simple" YAML string"manually".
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license