aws-codedeploy: Unable to update custom deployment config due to InstallLatestAwsSdk change throwing config already exists

[nina-ctrlv]

Describe the bug

In #23591, InstallLatestAwsSdk had its default changed to false for custom resources. There is a flag that allows overriding the default, but that is only applicable for when creating a custom resource directly. The change also updated several L3 constructs such as CustomLambdaDeploymentConfig that create a custom resource and hardcoded the InstallLatestAwsSdk to false. The flag is only applied if a prop is not assigned so that behavior cannot be overridden. This is causing the resource to be updated but since the name is not changed, it tries to create the same deployment config which fails. We could rename the deployment config, but this is not rollback safe so it would be high risk. We could also remove traffic shifting altogether then update the version and add back traffic shifting, but this is also high risk and time consuming.

Expected Behavior

Be able to update the the aws-cdk version without the custom resource trying update and create a new deployment config

Current Behavior

The custom resource is updated since the InstallLatestAwsSdk is changing which causes the resource to try to create a new deployment config even though the deployment config is not changing

Reproduction Steps

Deploy with cdk version 2.59 or earlier and then try to deploy again with version 2.60 or greater

Possible Solution

Some options are:

1. Potentially swallow already exist exceptions (pro: this will allow any other updates to the custom resource that aren't intending to update the config itself can be done without interruption, con: this could unintentionally cause people to use the wrong config. This could probably be combatted by being able to set the behavior with a prop that is set for the construct where the default is that the exception is not swallowed)
2. Allow the InstallLatestAwsSdk to be overridden in the CustomLambdaDeploymentConfig by it being a prop option (pro: does not depend on the flag which may go away in the future, con: not similar to the other L3 constructs)
3. Make it so that the flag will override the custom lambda deployment config (pro: don't need to add it to the prop, con: flag may go away at some point and this will affect everyone who currently has the flag set to a specific value and may cause unnecessary updates as well)

Additional Information/Context

No response

CDK CLI Version

(not sure if that's different from aws-cdk)

Framework Version

No response

Node.js Version

16.x

OS

mac

Language

Typescript

Language Version

No response

Other information

No response

[pahud]

Agree. This seems to be a breaking change which causes the custom resource update.

[TheRealAmazonKendra]

This construct is deprecated. We suggest that you move to LambdaDeploymentConfig instead. From my testing of something unrelated, I have discovered that any update to the underlying custom resource will cause breakages as this construct attempts to replace the resource instead of updating it due to no api existing for updates. The only way to perform an update is to rename it.

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.