Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-lib): support bootstrap command #26205

Merged

Conversation

AntonioAngelino
Copy link
Contributor

The first iteration of @aws-cdk/cli-lib-alpha doesn't support the bootstrap command that is mandatory to deploy a new app via CDK.

This PR introduces the bootstrap command for the CLI.

Related: #15851


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jul 3, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jul 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 3, 2023 13:38
@github-actions github-actions bot added the p2 label Jul 3, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain changed the title feat(cli-lib-alpha): Added bootstrap command feat(cli-lib-alpha): bootstrap command Jul 3, 2023
@mrgrain mrgrain changed the title feat(cli-lib-alpha): bootstrap command feat(cli-lib-alpha): support bootstrap command Jul 3, 2023
@mrgrain mrgrain changed the title feat(cli-lib-alpha): support bootstrap command feat(cli-lib): support bootstrap command Jul 3, 2023
@mrgrain mrgrain added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jul 3, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 3, 2023 14:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2b0fd94
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9364e94 into aws:main Jul 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@AntonioAngelino AntonioAngelino deleted the feat-add-bootstrap-command-to-cli-lib branch July 3, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants