Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: organize output from CDK deploy with concurrency #27015

Closed
2 tasks
polothy opened this issue Sep 5, 2023 · 3 comments
Closed
2 tasks

cli: organize output from CDK deploy with concurrency #27015

polothy opened this issue Sep 5, 2023 · 3 comments
Assignees
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@polothy
Copy link
Contributor

polothy commented Sep 5, 2023

Describe the feature

Current behavior of a command like:

cdk deploy --all --concurrency 10

Is that all of the concurrent or parallel deployments stream to Stdout/Stderr at the same time. This makes it really difficult to see what is happening because progress is mixed between 10 stacks being deployed.

I have not see what happens in case of an error (I think I read somewhere it'll re-print?), but was thinking it might be hard to adopt this if I cannot figure out what happens on deployment failure.

Use Case

Reason for this feature request: being able to clearly understand what is happening during the deployment and (more importantly) to be able to debug when a deployment failure happens.

If deployment errors are re-printed clearly without intermixing multiple deployments, we can probably close this issue.

Proposed Solution

Buffer the output of each deployment and only print to Stdout/Stderr when the deployment is done/failed.

Could also print other progress information, like "Deploying stack {stackName} ({stackId}) 2 of 10 stacks"

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.93.0

Environment details (OS name and version, etc.)

macOS

@polothy polothy added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 5, 2023
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2023
@khushail
Copy link
Contributor

khushail commented Sep 5, 2023

Hi @polothy , I am not clear about your requirement here. I tried deploying 3 stacks in parellel and reproduced this output for deployment failure , to share with you. Here we can see each stack name ,with its status and reason of failure.

Could you please share more about your requirement as what you want to see and what is missing here ?

Screenshot 2023-09-05 at 2 14 57 PM

@khushail khushail self-assigned this Sep 5, 2023
@khushail khushail added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Sep 5, 2023
@polothy
Copy link
Contributor Author

polothy commented Sep 6, 2023

First, thank you for trying this and posting a screenshot - this was really helpful.

I think I misinterpreted the output. It appears that while some things are mixed, the deployment status updates appear to be grouped. I'll re-try this and see how it goes.

@polothy polothy closed this as completed Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants