Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard naming scheme for feature flags to increase clarity #27058

Open
indrora opened this issue Sep 7, 2023 Discussed in #12576 · 0 comments
Open

Standard naming scheme for feature flags to increase clarity #27058

indrora opened this issue Sep 7, 2023 Discussed in #12576 · 0 comments
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. needs-design This feature request needs additional design work. needs-discussion This issue/PR requires more discussion with community. p3

Comments

@indrora
Copy link
Contributor

indrora commented Sep 7, 2023

Discussed in #12576

Originally posted by efenderbosch January 18, 2021
It is easy to understand what the aws-cdk:enableDiffNoFail feature flag does.

However, feature flag names like aws-cdk/secretsmanager:parseOwnedSecretName are unclear. I don't know by reading the flag name if if enabling the flag will include or exclude the suffix. A better name for this flag might be aws-cdk/secretsmanager:excludeSecretNameSuffix.
@indrora indrora added p2 feature-request A feature should be added or improved. needs-discussion This issue/PR requires more discussion with community. needs-design This feature request needs additional design work. labels Sep 7, 2023
@github-actions github-actions bot mentioned this issue Oct 1, 2023
Closed
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
@moelasmar moelasmar added the @aws-cdk/core Related to core CDK functionality label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. needs-design This feature request needs additional design work. needs-discussion This issue/PR requires more discussion with community. p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pahud @indrora @moelasmar