-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eks): support Bottlerocket Nvidia AMIs #28287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lpizzinidev , thank you for this contribution. It looks good to me, could you separate the appconfig alpha change to a separate PR since it is breaking.
@@ -444,7 +444,7 @@ export class Extension extends Resource implements IExtension { | |||
/** | |||
* The name of the extension. | |||
*/ | |||
public readonly name?: string; | |||
public readonly name: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callout:
Breaking Change.
@@ -565,7 +565,7 @@ export interface IExtension extends IResource { | |||
/** | |||
* The name of the extension. | |||
*/ | |||
readonly name?: string; | |||
readonly name: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callout:
Breaking Change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could you add this as a separate PR. We can then mark it as a Breaking Change PR.
Ohh, the build is failing. |
I see it is failing for |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Pull request has been modified.
@vinayak-kukreja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lpizzinidev , no worries 😄 Thank you for addressing the feedback.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Adds support for
BOTTLEROCKET_ARM_64_NVIDIA
andBOTTLEROCKET_x86_64_NVIDIA
AMI types.Closes #28241.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license