-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integ-runner: "Could not checkout snapshot directory" if HEAD branch does not contain snapshots #29278
Comments
@pahud thanks for attempting. I'll see if I can catch it happen again, and if it does I'll try to debug into cdk a bit... |
I haven't had this error happen again, so going to close this issue for now. |
|
@pahud I am reopening this issue since I got it to happen again. I think this happens if you work on a branch, and your This comment doesn't really make sens to me: https://github.com/aws/aws-cdk/blob/main/packages/@aws-cdk/integ-runner/lib/runner/integ-test-runner.ts#L94-L105
But that function tries to overwrite your current snapshot in your branch with whatever is in So in my repro steps, that would mean doing a Is this checkout logic specific to how aws operates and uses this to test cdk itself? It doesn't seem valid for general/public use... what branch I'm currently working in has no relation to edit: I was trying to think through some examples to support my statement of
but maybe I'm just projecting my specific use case... at my employer specifically it doesn't work well because we have multiple logical 'head' branches, where we have some diverged code that supports different deployment environments (where aws deployed assets may be different). There is no single logical My initial thought was that if you were working on something like a release branch that is a maybe a month old, then pulling a snapshot from Maybe a contrived example would be something like if you ran a git repo with major versions as branches, and they were unrelated in terms of code. Like |
Describe the bug
Running
integ-runner
results in a git failures:The message:
Looks like it doesn't include the
test/
path in thegit
command.Expected Behavior
Test should pass and update snapshot. (Ideally there shouldn't be
git
lock-in here either, but I guess that is a different discussion).Current Behavior
(See error message above)
Reproduction Steps
Have an test in the default
test/
directory. In my casetest/integ.getConfiguration.ts
Run
integ-runner --force
once. The snapshot is created ingit add
andgit commit
the snapshot, as is recommended in the integ-runner docs.Run
integ-runner --force
again.Results in the error message listed above.
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.129.0 (build d5ab0df)
Framework Version
No response
Node.js Version
v20.9.0
OS
Mac
Language
TypeScript
Language Version
4.8.4
Other information
No response
The text was updated successfully, but these errors were encountered: