Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks]: add support for passing helm chart values to AlbController #29707

Open
1 of 2 tasks
mtrspringer opened this issue Apr 3, 2024 · 1 comment · May be fixed by #29723
Open
1 of 2 tasks

[aws-eks]: add support for passing helm chart values to AlbController #29707

mtrspringer opened this issue Apr 3, 2024 · 1 comment · May be fixed by #29723
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mtrspringer
Copy link

Describe the feature

Allow users to pass optional helm chart values to the aws-load-balancer-controller helm chart to configure its behavior.

Use Case

We are using AWS Firewall Manager as well as the wafv2.CfnWebACLAssociation construct to associate our load balancers with WAFs so that we don't have to hard-code the waf arn in our manifests. aws-load-balancer-controller is constantly removing these associations. We can disable this behavior by setting enableWafv2: false in the helm chart values. However, this is not currently possible without disabling the built-in albController and using the HelmChart construct directly.

Proposed Solution

expose an additional property values on the AlbControllerProps interface. Then apply the values to the defaults already being used when AlbController instantiates the HelmChart construct under the hood.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.133.0

Environment details (OS name and version, etc.)

MacOS Ventura 13.6.4

@mtrspringer mtrspringer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 3, 2024
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 3, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Apr 4, 2024
@khushail
Copy link
Contributor

khushail commented Apr 4, 2024

thanks @mtrspringer for submitting the request and PR contribution!

@khushail khushail added effort/small Small work item – less than a day of effort p2 and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants