Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-07: Update remaining parts of aws-cdk #29838

Open
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments
Open
Tracked by #29694

SDKv3-07: Update remaining parts of aws-cdk #29838

TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

This is the grab bag task to find all remaining uses of sdkv2 in aws-cdk and remove them.

Acceptance Criteria

  1. No uses of sdkv2 remain in aws-cdk
  2. All tests (unit and integ) pass post change.
@kuhe
Copy link

kuhe commented Jul 8, 2024

One of the remaining usages is https://github.com/search?q=repo%3Aaws%2Faws-cdk%20getEndpointSuffix&type=code the getEndpointSuffix function, which is private in the AWS SDK for JavaScript (v2) and shouldn't be used.

Getting an endpoint suffix from only a region isn't really something supported by the public API of the AWS SDK.
Consult internally with the AWS SDK for JavaScript team if you would like to work out how to resolve endpoints.

In the AWS SDK specification, an endpoint, and therefore including the suffix as well, cannot be accurately resolved without knowing the service, operation, region, and potentially several more parameters. An AWS service is free to send different operations to entirely arbitrary endpoints based on parameters to that particular invocation, so having only the region is not sufficient.

@ashishdhingra ashishdhingra added p2 feature-request A feature should be added or improved. effort/medium Medium work item – several days of effort labels Jul 31, 2024
@Garethp
Copy link

Garethp commented Aug 6, 2024

One of the other remaining usages is in the SDK Usages of Credential Providers. The current usage forces credential providers to wrap their credentials in AWS.Credentials from aws-sdk v2 as there's no class/interface in v3 that matches this interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants